Add qos_network_id option to ports create/update #422
Open
tduncan8 wants to merge 3 commits intophp-opencloud:masterfrom
Open
Add qos_network_id option to ports create/update #422tduncan8 wants to merge 3 commits intophp-opencloud:masterfrom
tduncan8 wants to merge 3 commits intophp-opencloud:masterfrom
Conversation
Member
|
Hello, Thank you for the PR. Could you create some tests for this feature? At least add a unit test with some real response from the server to make sure it is working properly. Like this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add qos_network_id to ports create/update to allow this field to be readable/writeable https://docs.openstack.org/api-ref/network/v2/index.html